On Fri, 6 Aug 2021 16:59:54 +0200 Pablo Neira Ayuso wrote:

On Fri, Aug 06, 2021 at 06:27:59AM -0700, Jakub Kicinski wrote:

quoted

On Fri,  6 Aug 2021 13:52:01 +0200 Pablo Neira Ayuso wrote:  

quoted

 		rcu_read_lock();
 
 		nf_conntrack_get_ht(&ct_hash, &hashsz);
 		if (i >= hashsz)
-			i = 0;
+			break;  

Sparse says there is a missing rcu_read_unlock() here.
Please follow up on this one.  

Right.

I can squash this fix and send another PR or send a follow up patch.

Let me know your preference.

Squash is better if you don't mind overwriting history.
I'll toss this version from patchwork, then.