Re: [PATCH net 3/9] netfilter: conntrack: collect all entries in one cycle
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2021-08-06 15:00:02
Also in:
netfilter-devel
On Fri, Aug 06, 2021 at 06:27:59AM -0700, Jakub Kicinski wrote:
On Fri, 6 Aug 2021 13:52:01 +0200 Pablo Neira Ayuso wrote:quoted
rcu_read_lock(); nf_conntrack_get_ht(&ct_hash, &hashsz); if (i >= hashsz) - i = 0; + break;Sparse says there is a missing rcu_read_unlock() here. Please follow up on this one.
Right. I can squash this fix and send another PR or send a follow up patch. Let me know your preference.