Re: net: intel/e1000e/netdev.c __ew32_prepare parameter not used?

Hi,

It seems the parameter `*hw` is not used.
Although I didn't find where `FWSM` is defined.

Should it be removed? Or is the parameter really needed?

static void __ew32_prepare(struct e1000_hw *hw)
{
    s32 i = E1000_ICH_FWSM_PCIM2PCI_COUNT;

    while ((er32(FWSM) & E1000_ICH_FWSM_PCIM2PCI) && --i)
        udelay(50);
}

If you have a look at the definition of er32() (which is a macro and
is defined in e1000.h, you'll see that the hw parameter is used
there without being a parameter of the macro itself. Thus if you'd
rename the parameter you'd get a build error. Not really the best
code to look at when you want to learn coding, because that's an
example how not to do things, IMHO.

-michael