Thread (3 messages) flat view 3 messages, 2 authors, 2021-08-03

net: intel/e1000e/netdev.c __ew32_prepare parameter not used?

From: Leandro Coutinho <hidden>
Date: 2021-08-02 14:56:12

Hi,

I'm a newbie and I was just looking at the code to learn.

It seems the parameter `*hw` is not used.
Although I didn't find where `FWSM` is defined.

Should it be removed? Or is the parameter really needed?
static void __ew32_prepare(struct e1000_hw *hw)
{
    s32 i = E1000_ICH_FWSM_PCIM2PCI_COUNT;

    while ((er32(FWSM) & E1000_ICH_FWSM_PCIM2PCI) && --i)
        udelay(50);
}
It's because it gives an impression that "hw" is being changed somehow.

If you think it should be removed, I can send a patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help