On Tue, Jul 27, 2021 at 12:35 PM Gerhard Engleder
[off-list ref] wrote:

On Tue, Jul 27, 2021 at 1:35 AM Rob Herring [off-list ref] wrote:

quoted

quoted

+properties:
+  compatible:
+    oneOf:

Don't need oneOf when there is only one entry.

I will fix that.

quoted

quoted

+      - enum:
+        - engleder,tsnep

tsnep is pretty generic. Only 1 version ever? Or differences are/will
be discoverable by other means.

Differences shall be detected by flags in the registers; e.g., a flag for
gate control support. Anyway a version may make sense. Can you
point to a good reference binding with versions? I did not find a
network controller binding with versions.

Some of the SiFive IP blocks have versions. Version numbers are the
exception though. Ideally they would correspond to some version of
your FPGA image. I just don't want to see 'v1' because that sounds
made up. The above string can mean 'v1' or whatever version you want.
I'm fine if you just add some description here about feature flag
registers.

quoted

quoted

+  reg: true

How many? And what is each entry if more than 1.

Only one. I will fix that.

quoted

quoted

+  interrupts: true

How many?

Only one. I will fix that.

quoted

quoted

+
+  local-mac-address: true
+  mac-address: true
+  nvmem-cells: true

How many?

Is that not inherited from ethernet-controller.yaml?
  nvmem-cells:
    maxItems: 1

Ah, right.

quoted

quoted

+  nvmem-cells-names: true

Need to define the names.

Is that not inherited from ethernet-controller.yaml?
  nvmem-cell-names:
    const: mac-address

Yes.

Rob