On Tue, Jul 27, 2021 at 1:35 AM Rob Herring [off-list ref] wrote:
quoted
+properties:
+ compatible:
+ oneOf:
Don't need oneOf when there is only one entry.
I will fix that.
quoted
+ - enum:
+ - engleder,tsnep
tsnep is pretty generic. Only 1 version ever? Or differences are/will
be discoverable by other means.
Differences shall be detected by flags in the registers; e.g., a flag for
gate control support. Anyway a version may make sense. Can you
point to a good reference binding with versions? I did not find a
network controller binding with versions.
quoted
+ reg: true
How many? And what is each entry if more than 1.
Only one. I will fix that.
quoted
+ interrupts: true
How many?
Only one. I will fix that.
quoted
+
+ local-mac-address: true
+ mac-address: true
+ nvmem-cells: true
How many?
Is that not inherited from ethernet-controller.yaml?
nvmem-cells:
maxItems: 1
quoted
+ nvmem-cells-names: true
Need to define the names.
Is that not inherited from ethernet-controller.yaml?
nvmem-cell-names:
const: mac-address
quoted
+ phy-connection-type: true
+ phy-mode: true
All the modes the generic binding support are supported by this device?
Only GMII and RGMII are supported. I will fix that.
quoted
+ phy-handle: true
+
+ '#address-cells':
+ description: Number of address cells for the MDIO bus.
No need to re-describe common properties unless you have something
special to say.
Anyway, put an MDIO bus under an 'mdio' node.
quoted
+ const: 1
+
+ '#size-cells':
+ description: Number of size cells on the MDIO bus.
+ const: 0
+
+patternProperties:
+ "^ethernet-phy@[0-9a-f]$":
+ type: object
+ $ref: ethernet-phy.yaml#
Referencing mdio.yaml will do all this.
I will reference mdio.yaml.