On Thu, Jul 15, 2021 at 7:44 PM Joakim Zhang [off-list ref] wrote:

quoted

-----Original Message-----
From: Dong Aisheng <redacted>
Sent: 2021年7月15日 19:36
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Joakim Zhang <redacted>; Aisheng Dong
[off-list ref]; devicetree [off-list ref];
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
[off-list ref]; dl-linux-imx [off-list ref];
Sascha Hauer [off-list ref]; Rob Herring [off-list ref];
Shawn Guo [off-list ref]; linux-can@vger.kernel.org;
netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile

On Thu, Jul 15, 2021 at 7:07 PM Marc Kleine-Budde [off-list ref]
wrote:

quoted

On 15.07.2021 11:00:07, Joakim Zhang wrote:

quoted

quoted

I checked with Joakim that the flexcan on MX8MP is derived from
MX6Q with extra ECC added. Maybe we should still keep it from HW point

of view?

quoted

quoted

Sorry, Aisheng, I double check the history, and get the below results:

8MP reuses 8QXP(8QM), except ECC_EN
(ipv_flexcan3_syn_006/D_IP_FlexCAN3_SYN_057 which corresponds to
version d_ip_flexcan3_syn.03.00.17.01)

Also see commit message of:

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
.kernel.org%2Flinux-can%2F20200929211557.14153-2-qiangqing.zhang%40n

xp

quoted

.com%2F&data=04%7C01%7Cqiangqing.zhang%40nxp.com%7Cf5cd871

e13b34e9

quoted

5817b08d9478504af%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C
6376194

quoted

58893680146%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
oiV2luMz

quoted

IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YwH3vD%2FtIol5
OXPHPM

quoted

VbiVCLTC7gowOdIP3Ih1lBHh0%3D&reserved=0

quoted

I prefer to change the dtsi as Mac suggested if possible, shall I
send a fix patch?

Make it so!

Then should it be "fsl,imx8mp-flexcan", "fsl,imx8qxp-flexcan" rather than only
drop "fsl,imx6q-flexcan"?

No, I will only use " fsl,imx8mp-flexcan" to avoid ECC impact.

Is ECC issue SW or HW compatibility issue?
If SW, then we should keep the backward compatible string as DT is
describing HW.

Regards
Aisheng

Best Regards,
Joakim Zhang

quoted

Regards
Aisheng

quoted

regards,
Marc

--
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   |

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p
engutronix.de%2F&data=04%7C01%7Cqiangqing.zhang%40nxp.com%7Cf
5cd871e13b34e95817b08d9478504af%7C686ea1d3bc2b4c6fa92cd99c5c30163
5%7C0%7C1%7C637619458893680146%7CUnknown%7CTWFpbGZsb3d8eyJWI
joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
000&sdata=soLd53hGDcxtF42AjJ7u5k9TT%2FsZt6TG%2Bljw4rvtdy4%3D&
amp;reserved=0  |

quoted

Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |