Hi Aisheng, Marc,

-----Original Message-----
From: Dong Aisheng <redacted>
Sent: 2021年7月15日 18:46
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>; devicetree
[off-list ref]; moderated list:ARM/FREESCALE IMX / MXC
ARM ARCHITECTURE [off-list ref]; dl-linux-imx
[off-list ref]; Sascha Hauer [off-list ref]; Rob Herring
[off-list ref]; Shawn Guo [off-list ref]; Joakim Zhang
[off-list ref]; linux-can@vger.kernel.org;
netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile

Hi Marc,

On Thu, Jul 15, 2021 at 5:12 PM Marc Kleine-Budde [off-list ref]
wrote:

quoted

On 15.07.2021 16:25:30, Dong Aisheng wrote:

quoted

This patch fixes the following errors during make dtbs_check:
arch/arm64/boot/dts/freescale/imx8mp-evk.dt.yaml: can@308c0000:

compatible: 'oneOf' conditional failed, one must be fixed:

quoted

quoted

      ['fsl,imx8mp-flexcan', 'fsl,imx6q-flexcan'] is too long

IIRC the fsl,imx6q-flexcan binding doesn't work on the imx8mp. Maybe
better change the dtsi?

I checked with Joakim that the flexcan on MX8MP is derived from MX6Q with
extra ECC added. Maybe we should still keep it from HW point of view?

Sorry, Aisheng, I double check the history, and get the below results:

8MP reuses 8QXP(8QM), except ECC_EN (ipv_flexcan3_syn_006/D_IP_FlexCAN3_SYN_057 which corresponds to version d_ip_flexcan3_syn.03.00.17.01)

I prefer to change the dtsi as Mac suggested if possible, shall I send a fix patch?
 
Best Regards,
Joakim Zhang

Regards
Aisheng

quoted

regards,
Marc

--
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   |

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p
engutronix.de%2F&data=04%7C01%7Cqiangqing.zhang%40nxp.com%7Ce
df7b681c04c48c0695e08d9477e03b0%7C686ea1d3bc2b4c6fa92cd99c5c30163
5%7C0%7C0%7C637619428815826860%7CUnknown%7CTWFpbGZsb3d8eyJWI
joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1
000&sdata=Sd01Qk9H%2F8pBD0FAFQdQnQU9qp%2Br2ItGKdljK%2BWTiG
Q%3D&reserved=0  |

quoted

Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |