Re: [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case

Cong Wang wrote:

On Tue, Jul 6, 2021 at 9:31 AM John Fastabend [off-list ref] wrote:

quoted

If skb_linearize is needed and fails we could leak a msg on the error
handling. To fix ensure we kfree the msg block before returning error.
Found during code review.

sk_psock_skb_ingress_self() also needs the same fix, right?

Yep.

Other than this, it looks good to me.

I'll do another spin to get the other one as well. Mind as well
fix both cases at once.

Thanks.