[PATCH bpf v3 0/2] potential sockmap memleak and proc stats fix · John Fastabend <john.fastabend@gmail.com> · 2021-07-06
[PATCH bpf v3 2/2] bpf, sockmap: sk_prot needs inuse_idx set for proc stats · John Fastabend <john.fastabend@gmail.com> · 2021-07-06
Re: [PATCH bpf v3 2/2] bpf, sockmap: sk_prot needs inuse_idx set for proc stats · Cong Wang <hidden> · 2021-07-08
Re: [PATCH bpf v3 2/2] bpf, sockmap: sk_prot needs inuse_idx set for proc stats · Jakub Sitnicki <jakub@cloudflare.com> · 2021-07-12
Re: [PATCH bpf v3 2/2] bpf, sockmap: sk_prot needs inuse_idx set for proc stats · John Fastabend <john.fastabend@gmail.com> · 2021-07-12
[PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case · John Fastabend <john.fastabend@gmail.com> · 2021-07-06
Re: [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case · Cong Wang <hidden> · 2021-07-08
Re: [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case · John Fastabend <john.fastabend@gmail.com> · 2021-07-08

Re: [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case

From: Cong Wang <hidden>
Date: 2021-07-08 19:38:54
Also in: bpf

On Tue, Jul 6, 2021 at 9:31 AM John Fastabend [off-list ref] wrote:

If skb_linearize is needed and fails we could leak a msg on the error
handling. To fix ensure we kfree the msg block before returning error.
Found during code review.

sk_psock_skb_ingress_self() also needs the same fix, right?
Other than this, it looks good to me.

Thanks.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help