Re: [PATCHv1 2/3] ARM: dts: meson: Use new reset id for reset controller
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2021-07-30 09:46:04
Also in:
linux-amlogic, linux-arm-kernel, linux-devicetree, lkml
On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote:
quoted hunk ↗ jump to hunk
Used new reset id for reset controller as it conflict with the core reset id. Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description") Cc: Jerome Brunet <jbrunet@baylibre.com> Cc: Neil Armstrong <redacted> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Signed-off-by: Anand Moon <redacted> --- arch/arm/boot/dts/meson8b.dtsi | 2 +- arch/arm/boot/dts/meson8m2.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi index c02b03cbcdf4..cb3a579d09ef 100644 --- a/arch/arm/boot/dts/meson8b.dtsi +++ b/arch/arm/boot/dts/meson8b.dtsi@@ -511,7 +511,7 @@ ðmac { tx-fifo-depth = <2048>; resets = <&reset RESET_ETHERNET>; - reset-names = "stmmaceth"; + reset-names = "ethreset";
This looks like an incompatible change. Is the "stmmaceth" reset not used? It is documented as "MAC reset signal" in [1]. So a PHY reset should be separate from this. [1] Documentation/devicetree/bindings/net/snps,dwmac.yaml regards Philipp