Re: [PATCH bpf-next v1 2/5] af_unix: add unix_stream_proto for sockmap

Cong Wang wrote:

On Tue, Jul 27, 2021 at 9:37 AM John Fastabend [off-list ref] wrote:

quoted

Do we really need an unhash hook for unix_stream? I'm doing some testing
now to pull it out of TCP side as well. It seems to be an artifact of old
code that is no longer necessary. On TCP side at least just using close()
looks to be enough now.

How do you handle the disconnection from remote without ->unhash()?

Would close() not work for stream/dgram sockets?

For all stream sockets, we still only allow established sockets to stay
in sockmap, which means we have to remove it if it is disconnected
or closed.

+1.

But it seems Jiang forgot to call ->unhash() when disconnecting.

Aha so we need to add it in af_unix code I guess. Anyways looking forward
to v2.

Thanks.