Thread (16 messages) 16 messages, 4 authors, 2021-08-10

Re: [PATCH bpf-next v1 2/5] af_unix: add unix_stream_proto for sockmap

From: Cong Wang <hidden>
Date: 2021-07-28 02:07:59
Also in: bpf, linux-kselftest, lkml

On Tue, Jul 27, 2021 at 9:37 AM John Fastabend [off-list ref] wrote:
Do we really need an unhash hook for unix_stream? I'm doing some testing
now to pull it out of TCP side as well. It seems to be an artifact of old
code that is no longer necessary. On TCP side at least just using close()
looks to be enough now.
How do you handle the disconnection from remote without ->unhash()?

For all stream sockets, we still only allow established sockets to stay
in sockmap, which means we have to remove it if it is disconnected
or closed.

But it seems Jiang forgot to call ->unhash() when disconnecting.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help