Re: [PATCH 1/6] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/G2L SoC
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-07-16 07:38:46
Also in:
linux-can, linux-clk, linux-devicetree, linux-renesas-soc, lkml
Hi Prabhakar, On Thu, Jul 15, 2021 at 8:21 PM Lad Prabhakar [off-list ref] wrote:
Add CANFD binding documentation for Renesas RZ/G2L SoC. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
quoted hunk ↗ jump to hunk
@@ -78,6 +79,38 @@ patternProperties: node. Each child node supports the "status" property only, which is used to enable/disable the respective channel. +if: + properties: + compatible: + contains: + enum: + - renesas,rzg2l-canfd +then: + properties: + interrupts: + items: + - description: CAN global error interrupt + - description: CAN receive FIFO interrupt + - description: CAN0 error interrupt + - description: CAN0 transmit interrupt + - description: CAN0 transmit/receive FIFO receive completion interrupt + - description: CAN1 error interrupt + - description: CAN1 transmit interrupt + - description: CAN1 transmit/receive FIFO receive completion interrupt
Does it make sense to add interrupt-names?
+ + resets: + maxItems: 2
Same here, for reset-names? Or a list of descriptions, so we know which reset serves what purpose.
+ +else: + properties: + interrupts: + items: + - description: Channel interrupt + - description: Global interrupt + + resets: + maxItems: 1 + required: - compatible - reg
The rest looks good to me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds