Re: [PATCH v2 2/3] net/ncsi: add NCSI Intel OEM command to keep PHY up

On Mon, 2021-07-12 at 10:01 +0000, Joel Stanley wrote:

On Thu, 8 Jul 2021 at 12:27, Ivan Mikhaylov [off-list ref] wrote:

quoted

This allows to keep PHY link up and prevents any channel resets during
the host load.

It is KEEP_PHY_LINK_UP option(Veto bit) in i210 datasheet which
block PHY reset and power state changes.

How about using runtime configuration over using kconfig for this, so
the same kernel config can be used on different machines. Something
device tree based?

As I see there is already the way with Kconfig option, with previous
broadcom/mellanox get mac address and set affinity for mellanox commands.
I'm not sure about dts based solution. As I see there is two ways:
1. make everything related OEM into dts based options
2. or this way, with Kconfig

Another option is to use the netlink handler to send the OEM command
from userspace. Eddie has worked on this for an IBM machine, and I've
asked him to post those changes. I would prefer the kernel option
though.

I like the idea, it may help with debugging.

Thanks.