Re: [PATCH v2 3/3] net/ncsi: add dummy response handler for Intel boards

On Mon, 2021-07-12 at 10:03 +0000, Joel Stanley wrote:

On Thu, 8 Jul 2021 at 12:28, Ivan Mikhaylov [off-list ref] wrote:

quoted

Add the dummy response handler for Intel boards to prevent incorrect
handling of OEM commands.

What do you mean?

When you don't have proper OEM handler for your MFR_ID, you'll get this as
example:
[   39.073873] ftgmac100 1e660000.ethernet eth1: Received unrecognized OEM
packet with MFR-ID (0x157)
[   39.082974] ftgmac100 1e660000.ethernet eth1: NCSI: Handler for packet type
0xd0 returned -2

Is this to handle the response to the link up OEM command? If so,
include it in the same patch.

It is not the response, it's provides same way of handling as for broadcom and
mellanox manufacturers.

Can you check that the response is to the link up command and print a
warning if not?

Yes, I can. As example, ncsi_oem_smaf_mlx doesn't check the response, for me
it's like unidirectional commands, same for this one.

Thanks.