Re: [PATCH iproute2-next v2 1/3] Add, show, link, remove IOAM namespaces and schemas
From: David Ahern <hidden>
Date: 2021-07-29 02:41:41
On 7/24/21 11:21 AM, Justin Iurman wrote:
quoted hunk ↗ jump to hunk
+static void print_schema(struct rtattr *attrs[]) +{ + __u8 data[IOAM6_MAX_SCHEMA_DATA_LEN + 1]; + int len; + + print_uint(PRINT_ANY, "schema", "schema %u", + rta_getattr_u32(attrs[IOAM6_ATTR_SC_ID])); + + if (attrs[IOAM6_ATTR_NS_ID]) + print_uint(PRINT_ANY, "namespace", " [namespace %u]", + rta_getattr_u16(attrs[IOAM6_ATTR_NS_ID])); + + len = RTA_PAYLOAD(attrs[IOAM6_ATTR_SC_DATA]); + memcpy(data, RTA_DATA(attrs[IOAM6_ATTR_SC_DATA]), len); + data[len] = '\0'; + + print_string(PRINT_ANY, "data", ", data \"%s\"", (const char *)data);
The attribute descriptions shows this as binary data, not a string.
quoted hunk ↗ jump to hunk
+ print_null(PRINT_ANY, "", "\n", NULL); +} + +static int process_msg(struct nlmsghdr *n, void *arg) +{ + struct rtattr *attrs[IOAM6_ATTR_MAX + 1]; + struct genlmsghdr *ghdr; + int len = n->nlmsg_len; + + if (n->nlmsg_type != genl_family) + return -1; + + len -= NLMSG_LENGTH(GENL_HDRLEN); + if (len < 0) + return -1; + + ghdr = NLMSG_DATA(n); + parse_rtattr(attrs, IOAM6_ATTR_MAX, (void *)ghdr + GENL_HDRLEN, len); + + open_json_object(NULL); + switch (ghdr->cmd) { + case IOAM6_CMD_DUMP_NAMESPACES: + print_namespace(attrs); + break; + case IOAM6_CMD_DUMP_SCHEMAS: + print_schema(attrs); + break; + } + close_json_object(); + + return 0; +} + +static int ioam6_do_cmd(void) +{ + IOAM6_REQUEST(req, 1036, opts.cmd, NLM_F_REQUEST); + int dump = 0; + + if (genl_family < 0) { + if (rtnl_open_byproto(&grth, 0, NETLINK_GENERIC) < 0) { + fprintf(stderr, "Cannot open generic netlink socket\n"); + exit(1); + } + genl_family = genl_resolve_family(&grth, IOAM6_GENL_NAME);
The above 2 calls can be done with genl_init_handle.
quoted hunk ↗ jump to hunk
+ if (genl_family < 0) + exit(1); + req.n.nlmsg_type = genl_family; + } +
quoted hunk ↗ jump to hunk
+int do_ioam6(int argc, char **argv) +{ + bool maybe_wide = false; + + if (argc < 1 || matches(*argv, "help") == 0) + usage(); + + memset(&opts, 0, sizeof(opts)); + + if (matches(*argv, "namespace") == 0) {
matches has been shown to be quite frail. Convenient for shorthand typing commands, but frail in the big picture. We should stop using it - especially for new commands.