Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for requeued SKBs

On Mon, Jul 12, 2021 at 7:07 PM Tonghao Zhang [off-list ref] wrote:

On Mon, Jul 12, 2021 at 12:17 PM Tonghao Zhang [off-list ref] wrote:

quoted

On Mon, Jul 12, 2021 at 11:51 AM Cong Wang [off-list ref] wrote:

quoted

On Sat, Jul 10, 2021 at 10:00 PM [off-list ref] wrote:

quoted

From: Tonghao Zhang <redacted>

The main purpose of this tracepoint is to monitor what,
how many and why packets were requeued. The txq_state can
be used for determining the reason for packets requeued.

Hmm, how can I figure out the requeue is caused by
validate_xmit_skb_list() when it returns again==true?

Hi cong
Consider this patch again.
The main purpose of this tracepoint is to monitor what, how many and
why packets were requeued.
So should we figure out packets required by validate_xmit_skb_list or
dev_hard_start_xmit ?
because we may want to know what packets were requeued and how many.

if we should figure out, we can add more arg for trace, right ?

Figuring out which case is important to determine the cause,
so you have to fix it to make it useful.

Thanks.