Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for requeued SKBs

On Mon, Jul 12, 2021 at 11:51 AM Cong Wang [off-list ref] wrote:

On Sat, Jul 10, 2021 at 10:00 PM [off-list ref] wrote:

quoted

From: Tonghao Zhang <redacted>

The main purpose of this tracepoint is to monitor what,
how many and why packets were requeued. The txq_state can
be used for determining the reason for packets requeued.

Hmm, how can I figure out the requeue is caused by
validate_xmit_skb_list() when it returns again==true?
I fail to see you trace it.

This patch looks not good.

For the other case, we can figure it out by trace_net_dev_xmit().
So, in short, your patch looks useless.

Thanks.

--
Best regards, Tonghao