Re: [RESEND PATCH V3 2/6] PCI: Use cached Device Capabilities 2 Register

On 2021/6/14 13:49, Christoph Hellwig wrote:

quoted

+			if (!(bridge->pcie_devcap2 & PCI_EXP_DEVCAP2_ATOMIC_ROUTE))

Overly long line.

Will fix.

quoted

+static void pci_init_devcap2(struct pci_dev *dev)
+{
+	if (!pci_is_pcie(dev))
+		return;
+
+	pcie_capability_read_dword(dev, PCI_EXP_DEVCAP2, &dev->pcie_devcap2);
+}

Wouldn't it make sene to merge this into set_pcie_port_type?

Good suggestion, will do.

Thanks,
Dongdong

.