Re: [RESEND PATCH V3 4/6] PCI: Enable 10-Bit tag support for PCIe Endpoint devices
flat view
From: Christoph Hellwig <hch@infradead.org>
Date: 2021-06-14 05:55:04
Also in:
linux-media, linux-pci
On Sun, Jun 13, 2021 at 05:29:13PM +0800, Dongdong Liu wrote:
quoted hunk ↗ jump to hunk
+static void pci_configure_10bit_tags(struct pci_dev *dev) +{ + struct pci_dev *bridge; + + if (!pci_is_pcie(dev)) + return; + + if (!(dev->pcie_devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_COMP)) + return;
Doesn't the second check imply the first one? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>