Re: [net-next: PATCH v3 4/6] net: mvmdio: add ACPI support

On Wed, Jun 23, 2021 at 11:58:14PM +0200, Marcin Wojtas wrote:

śr., 23 cze 2021 o 22:28 Andrew Lunn [off-list ref] napisał(a):

quoted

On Mon, Jun 21, 2021 at 07:30:26PM +0200, Marcin Wojtas wrote:

quoted

This patch introducing ACPI support for the mvmdio driver by adding
acpi_match_table with two entries:

* "MRVL0100" for the SMI operation
* "MRVL0101" for the XSMI mode

Same as the freescale MDIO bus driver, you should add

depends on FWNODE_MDIO

Otherwise you might find randconfig builds end up with it disabled,
and then linker errors.

The CONFIG_MVMDIO is selected by CONFIG_MV643XX_ETH and actually there
is a real example of the previously discussed fallback to the
mdiobus_register() (without DT/ACPI and now FWNODE_MDIO). I just
checked and successfully built the kernel out of the dove_defconfig. I
only needed below fix, that will be submitted in v4:

You could be correct, but i've seen randconfig builds find issues. So
i tend to add dependencies to avoid possible problems.  Such problem
reports tend to come weeks later, when Arnd does such builds.

	Andrew