Re: [net-next: PATCH v3 5/6] net: mvpp2: enable using phylink with ACPI
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-06-23 20:37:23
Also in:
lkml
quoted hunk ↗ jump to hunk
+static bool mvpp2_use_acpi_compat_mode(struct fwnode_handle *port_fwnode) +{ + if (!is_acpi_node(port_fwnode)) + return false; + + return (!fwnode_property_present(port_fwnode, "phy-handle") && + !fwnode_property_present(port_fwnode, "managed") && + !fwnode_get_named_child_node(port_fwnode, "fixed-link"));
I'm not too sure about this last one. You only use fixed-link when
connecting to an Ethernet switch. I doubt anybody will try ACPI and a
switch. It has been agreed, ACPI is for simple hardware, and you need
to use DT for advanced hardware configurations.
What is your use case for fixed-link?
Andrew