Re: [PATCH] r8169: introduce polling method for link change

Hi Koba,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ipvs/master]
[also build test WARNING on linus/master v5.13-rc4 next-20210603]
[cannot apply to sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Koba-Ko/r8169-introduce-polling-method-for-link-change/20210603-105524
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: mips-randconfig-r014-20210603 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d8e0ae9a76a62bdc6117630d59bf9967ac9bb4ea)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/99be97b442a155a21c4a7e4a34a98da1258105f6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Koba-Ko/r8169-introduce-polling-method-for-link-change/20210603-105524
        git checkout 99be97b442a155a21c4a7e4a34a98da1258105f6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/realtek/r8169_main.c:4674:16: warning: unused variable 'flags' [-Wunused-variable]
           unsigned long flags;
                         ^

quoted

drivers/net/ethernet/realtek/r8169_main.c:181:35: warning: unused variable 'rtl8169_linkChg_polling_enabled' [-Wunused-const-variable]

   static const struct pci_device_id rtl8169_linkChg_polling_enabled[] = {
                                     ^
   drivers/net/ethernet/realtek/r8169_main.c:4684:20: warning: unused function 'rtl8169_delete_link_timer' [-Wunused-function]
   static inline void rtl8169_delete_link_timer(struct net_device *dev, struct timer_list *timer)
                      ^
   3 warnings generated.


vim +/rtl8169_linkChg_polling_enabled +181 drivers/net/ethernet/realtek/r8169_main.c

   180	
 > 181	static const struct pci_device_id rtl8169_linkChg_polling_enabled[] = {
   182		{ PCI_VDEVICE(REALTEK, 0x8136), RTL_CFG_NO_GBIT },
   183		{ 0 }
   184	};
   185	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org