Re: [PATCH net-next 06/10] net: iosm: drop custom netdev(s) removing

From
Kumar, M Chetan <hidden>
Date
2021-06-30 05:11:55
Reply to
Loic Poulain, 2021-06-29
Hi Loic,

On 6/29/2021 8:59 PM, Loic Poulain wrote:
Hi Chetan,

On Tue, 29 Jun 2021 at 16:56, Kumar, M Chetan [off-list ref] wrote:
quoted
Hi Loic,

On 6/29/2021 7:44 PM, Loic Poulain wrote:
quoted
quoted
quoted
BTW, if IOSM modems have a default data channel, I can add a separate
patch to the series to create a default network interface for IOSM if you tell
me which link id is used for the default data channel.
Link id 1 is always associated as default data channel.
Quick question, Isn't your driver use MBIM session IDs? with
session-ID 0 as the default one?
Link Id from 1 to 8 are treated as valid link ids. These ids are
decremented by 1 to match session id.

In this case link id 1 would be mapped to session id 0. So have
requested link id 1 to be set as default data channel.
Oh ok, but why? it seems quite confusing, that means a user creating a
MBIM session 0 has to create a link with ID 1?
It seems to be quite specific to your driver, can't you simply handle
ID 0 from user? to keep aligned with other drivers.
Thought link id 0 is not a valid id so had considered it from 1 :(

Sure, We will correct it to be intact with other drivers.

Regards,
Chetan
Thread (29 messages) 29 messages, 4 authors, last reply 2021-06-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help