Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver

On Mon, Jun 21, 2021 at 05:05:06AM +0000, Liang Xu wrote:

On 21/6/2021 10:30 am, Andrew Lunn wrote:

quoted

This email was sent from outside of MaxLinear.


On Fri, Jun 18, 2021 at 03:36:35PM +0000, Liang Xu wrote:

quoted

On 18/6/2021 10:01 pm, Andrew Lunn wrote:

quoted

This email was sent from outside of MaxLinear.

quoted

Net-next:

int genphy_loopback(struct phy_device *phydev, bool enable)
{
       if (enable) {
           u16 val, ctl = BMCR_LOOPBACK;
           int ret;

           if (phydev->speed == SPEED_1000)
               ctl |= BMCR_SPEED1000;
           else if (phydev->speed == SPEED_100)
               ctl |= BMCR_SPEED100;

The problem happens in the speed change no matter it's forced or
auto-neg in our device.

You say speed change. So do you just need to add support for 10Mbps,
so there is no speed change? Or are you saying phydev->speed does not
match the actual speed?

       Andrew

We have 2.5G link speed, so mismatch happens.

Ah, yes.  Sorry.

Please implement it in your driver.

       Andrew