Re: [EXT] Re: [net-next PATCH 1/5] octeontx2-af: cn10k: Bandwidth profiles config support
From: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Date: 2021-06-21 10:19:19
Hi Kees Cook, Thanks. I will send the fix to net. Sundeep ________________________________________ From: Kees Cook <redacted> Sent: Friday, June 18, 2021 9:37 PM To: Subbaraya Sundeep Bhatta Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org; Sunil Kovvuri Goutham; Hariprasad Kelam; Geethasowjanya Akula Subject: [EXT] Re: [net-next PATCH 1/5] octeontx2-af: cn10k: Bandwidth profiles config support External Email ---------------------------------------------------------------------- On Tue, Jun 15, 2021 at 05:04:27PM +0530, Subbaraya Sundeep wrote:
quoted hunk ↗ jump to hunk
[...]@@ -885,6 +906,9 @@ static int rvu_nix_blk_aq_enq_inst(struct rvu *rvu, struct nix_hw *nix_hw, else if (req->ctype == NIX_AQ_CTYPE_MCE) memcpy(&rsp->mce, ctx, sizeof(struct nix_rx_mce_s)); + else if (req->ctype == NIX_AQ_CTYPE_BANDPROF) + memcpy(&rsp->prof, ctx, + sizeof(struct nix_bandprof_s));
rsp->prof is u64 not struct nix_bandprof_s, so the compiler thinks this memcpy() is overflowing the "prof" field. Can you please fix this up? -- Kees Cook