Thread (9 messages) flat view 9 messages, 3 authors, 2021-06-21

Re: [net-next PATCH 1/5] octeontx2-af: cn10k: Bandwidth profiles config support

From: Kees Cook <hidden>
Date: 2021-06-18 16:08:22

On Tue, Jun 15, 2021 at 05:04:27PM +0530, Subbaraya Sundeep wrote:
quoted hunk ↗ jump to hunk
[...]
@@ -885,6 +906,9 @@ static int rvu_nix_blk_aq_enq_inst(struct rvu *rvu, struct nix_hw *nix_hw,
 			else if (req->ctype == NIX_AQ_CTYPE_MCE)
 				memcpy(&rsp->mce, ctx,
 				       sizeof(struct nix_rx_mce_s));
+			else if (req->ctype == NIX_AQ_CTYPE_BANDPROF)
+				memcpy(&rsp->prof, ctx,
+				       sizeof(struct nix_bandprof_s));
rsp->prof is u64 not struct nix_bandprof_s, so the compiler thinks this
memcpy() is overflowing the "prof" field.

Can you please fix this up?

-- 
Kees Cook
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help