Re: [RFT net-next] net: ti: add pp skb recycling support

On 6/9/21 5:55 PM, Jesper Dangaard Brouer wrote:

On Wed, 9 Jun 2021 17:43:57 +0200
Matteo Croce [off-list ref] wrote:

quoted

On Wed, Jun 9, 2021 at 5:03 PM Grygorii Strashko
[off-list ref] wrote:

quoted

On 09/06/2021 15:20, Matteo Croce wrote:  

quoted

On Wed, Jun 9, 2021 at 2:01 PM Lorenzo Bianconi [off-list ref] wrote:  

quoted

As already done for mvneta and mvpp2, enable skb recycling for ti
ethernet drivers

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>  

Looks good! If someone with the HW could provide a with and without
the patch, that would be nice!
 

What test would you recommend to run?

[...]

quoted

A test which benefits most from this kind of change is one in which
the frames are freed early.

I would also recommend running an XDP_PASS program, and then running
something that let the packets travel as deep as possible into netstack.
Not to test performance, but to make sure we didn't break something!

I've hacked up bnxt driver (it's not as straight forward as this driver
to convert) and is running some TCP tests.  Not problems so-far :-0

I wanted to ask if someone knows howto setup the zero-copy TCP stuff
that google did? (but is that TX only?)

TX does not need anything fancy really.

For RX part, you can look at https://netdevconf.info/0x14/pub/slides/62/Implementing%20TCP%20RX%20zero%20copy.pdf