Re: [RFT net-next] net: ti: add pp skb recycling support

On Wed, Jun 9, 2021 at 5:03 PM Grygorii Strashko
[off-list ref] wrote:

hi

On 09/06/2021 15:20, Matteo Croce wrote:

quoted

On Wed, Jun 9, 2021 at 2:01 PM Lorenzo Bianconi [off-list ref] wrote:

quoted

As already done for mvneta and mvpp2, enable skb recycling for ti
ethernet drivers

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Looks good! If someone with the HW could provide a with and without
the patch, that would be nice!

What test would you recommend to run?

--
Best regards,
grygorii

Hi Grygorii,

A test which benefits most from this kind of change is one in which
the frames are freed early.
One option would be to use mausezahn which by default sends frames
with an invalid ethertype, that are dropped very early from the stack
(I think in __netif_receive_skb_core() or near there).
Then, on the device I just watch the device statistics to count
packets per second:

mausezahn eth0 -c 0 -b $board_mac_address

This test should be precise enough for a gigabit link, on faster links
I usually use a DPDK or AF_XDP based one.

Regards,
-- 
per aspera ad upstream