Re: [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver

On 3/6/2021 5:17 pm, Russell King (Oracle) wrote:

quoted

+static int gpy_config_init(struct phy_device *phydev)
+{
+ int ret, fw_ver;
+
+ /* Show GPY PHY FW version in dmesg */
+ fw_ver = phy_read(phydev, PHY_FWV);
+ if (fw_ver < 0)
+ return fw_ver;
+
+ phydev_info(phydev, "Firmware Version: 0x%04X (%s)\n", fw_ver,
+ (fw_ver & PHY_FWV_REL_MASK) ? "release" : "test");

Does this need to print the firmware version each time config_init()
is called? Is it likely to change beyond? Would it be more sensible
to print it in the probe() method?

The firmware version can change in device with different firmware 
loading mechanism.

I moved the print to probe and tested a few devices, found in some cases 
it did not print the active version number.

So I'm thinking to keep it here to cover all scenarios.