Re: [PATCH net-next v4 2/5] ipv6: ioam: Data plane support for Pre-allocated Trace

On Mon, 31 May 2021 13:43:37 +0200 (CEST) Justin Iurman wrote:

quoted

BTW the ASCII art in patch 1 looks like node data is filled in in order  

I agree, this one could be quite confusing without the related
paragraph in the draft that explains it. Two possibilities here: (a)
add the paragraph in the patch description to remove ambiguity; or
(b) revert indexes in the ASCII art (from n to 0). Thoughts?

Inverting the indexes in the ASCII art would make it clear enough 
for me.

quoted

but:

+	data = trace->data + trace->remlen * 4 - trace->nodelen *
4 - sclen * 4;

Looks like we'd start from the last node data?  

Correct, it works as a stack from bottom (end of the pre-allocated
space) to top (start of the pre-allocated space).