Thread (13 messages) 13 messages, 3 authors, 2021-05-28

Re: [PATCH leds v1 3/5] leds: trigger: netdev: move trigger data structure to global include dir

From: Marek Behún <hidden>
Date: 2021-05-28 06:30:03
Also in: linux-leds

On Thu, 27 May 2021 18:48:21 +0200
Andrew Lunn [off-list ref] wrote:
On Wed, May 26, 2021 at 08:00:18PM +0200, Marek Behún wrote:
quoted
In preparation for HW offloading of netdev trigger, move struct
led_trigger_data into global include directory, into file
linux/ledtrig.h, so that drivers wanting to offload the trigger can
see the requested settings.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/leds/trigger/ledtrig-netdev.c | 23 +---------------
 include/linux/ledtrig.h               | 38
+++++++++++++++++++++++++++  
I'm wondering how this is going to scale, if we have a lot of triggers
which can be offloaded. Rather than try to pack them all into
one header, would it make more sense to add

include/linux/led/ledtrig-netdev.h

	Andrew
Hmm, I guess you are right. Also when looking at a LED controller
driver we could immediately see which triggers this driver can offload,
when looking at headers included.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help