Re: [PATCH leds v1 3/5] leds: trigger: netdev: move trigger data structure to global include dir
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-05-27 16:48:24
Also in:
linux-leds
On Wed, May 26, 2021 at 08:00:18PM +0200, Marek Behún wrote:
In preparation for HW offloading of netdev trigger, move struct led_trigger_data into global include directory, into file linux/ledtrig.h, so that drivers wanting to offload the trigger can see the requested settings. Signed-off-by: Marek Behún <kabel@kernel.org> --- drivers/leds/trigger/ledtrig-netdev.c | 23 +--------------- include/linux/ledtrig.h | 38 +++++++++++++++++++++++++++
I'm wondering how this is going to scale, if we have a lot of triggers which can be offloaded. Rather than try to pack them all into one header, would it make more sense to add include/linux/led/ledtrig-netdev.h Andrew