Thread (14 messages) 14 messages, 9 authors, 2021-05-24

virtio_net: BQL?

From: Dave Taht <hidden>
Date: 2021-05-17 18:43:58
Also in: lkml

Not really related to this patch, but is there some reason why virtio
has no support for BQL?

On Mon, May 17, 2021 at 11:41 AM Xianting Tian
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
BUG_ON() uses unlikely in if(), which can be optimized at compile time.

Signed-off-by: Xianting Tian <redacted>
---
  drivers/net/virtio_net.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index c921ebf3ae82..212d52204884 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1646,10 +1646,9 @@ static int xmit_skb(struct send_queue *sq, struct
sk_buff *skb)
        else
                hdr = skb_vnet_hdr(skb);

-       if (virtio_net_hdr_from_skb(skb, &hdr->hdr,
+       BUG_ON(virtio_net_hdr_from_skb(skb, &hdr->hdr,
                                    virtio_is_little_endian(vi->vdev), false,
-                                   0))
-               BUG();
+                                   0));

        if (vi->mergeable_rx_bufs)
                hdr->num_buffers = 0;
--
2.17.1

-- 
Latest Podcast:
https://www.linkedin.com/feed/update/urn:li:activity:6791014284936785920/

Dave Täht CTO, TekLibre, LLC
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help