[PATCH] virtio_net: Use BUG_ON instead of if condition followed by BUG
From: Xianting Tian <hidden>
Date: 2021-05-17 13:31:26
Also in:
lkml
Subsystem:
networking drivers, the rest, virtio net driver · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, "Michael S. Tsirkin", Jason Wang
BUG_ON() uses unlikely in if(), which can be optimized at compile time. Signed-off-by: Xianting Tian <redacted> --- drivers/net/virtio_net.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index c921ebf3ae82..212d52204884 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c@@ -1646,10 +1646,9 @@ static int xmit_skb(struct send_queue *sq, struct sk_buff *skb) else hdr = skb_vnet_hdr(skb); - if (virtio_net_hdr_from_skb(skb, &hdr->hdr, + BUG_ON(virtio_net_hdr_from_skb(skb, &hdr->hdr, virtio_is_little_endian(vi->vdev), false, - 0)) - BUG(); + 0)); if (vi->mergeable_rx_bufs) hdr->num_buffers = 0; -- 2.17.1