Re: [PATCH] net: mdio: octeon: Fix some double free issues
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-05-13 12:22:58
Also in:
kernel-janitors, lkml
On Thu, May 13, 2021 at 09:24:55AM +0200, Christophe JAILLET wrote:
'bus->mii_bus' has been allocated with 'devm_mdiobus_alloc_size()' in the
probe function. So it must not be freed explicitly or there will be a
double free.
Remove the incorrect 'mdiobus_free' in the error handling path of the
probe function and in remove function.
Suggested-By: Andrew Lunn <andrew@lunn.ch>
Fixes: 35d2aeac9810 ("phy: mdio-octeon: Use devm_mdiobus_alloc_size()")
Signed-off-by: Christophe JAILLET <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew