Re: [PATCH net-next v3 0/3] net/sched: act_vlan: Fix modify to allow 0

On 2021-05-31 7:57 a.m., Davide Caratti wrote:

On Sun, May 30, 2021 at 02:40:49PM +0300, Boris Sukholitko wrote:

quoted

Currently vlan modification action checks existence of vlan priority by
comparing it to 0. Therefore it is impossible to modify existing vlan
tag to have priority 0.

hello Boris, thanks for following up!
  

quoted

Change Log:
v2 -> v3:
- Push assumes that the priority is being set
- tcf_vlan_get_fill_size accounts for priority existence

Reviewed-by: Davide Caratti <redacted>

Looks good to me as well. And thanks for adding the tests!

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal