Re: [RFC PATCH v2 linux-next 13/14] net: dsa: sja1105: expose the SGMII PCS as an mdio_device
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-05-26 15:29:16
On Wed, May 26, 2021 at 04:55:34PM +0300, Vladimir Oltean wrote:
Since we touch all PCS accessors again, now it is a good time to check for error codes from the hardware access as well. We can't propagate the errors very far due to phylink returning void for mac_config and mac_link_up, but at least we print them to the console.
phylink doesn't have much option on what it could do if we error out at those points - I suppose we could print a non-specific error and then lock-out the interface in a similar way that phylib does, but to me that seems really unfriendly if you're remotely accessing a box and the error is intermittent. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!