Re: [RFC PATCH v2 linux-next 03/14] net: dsa: sja1105: the 0x1F0000 SGMII "base address" is actually MDIO_MMD_VEND2
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2021-05-26 15:25:09
On Wed, May 26, 2021 at 04:55:24PM +0300, Vladimir Oltean wrote:
- const struct sja1105_regs *regs = priv->info->regs; + u64 addr = (mmd << 16) | pcs_reg;
What is the reason for using "u64" here. pcs_reg is 16-bits, and mmd is five bits, which is well below 32 bits. So, why not u32? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!