Re: [PATCH net] netns: export get_net_ns_by_id()

Le 16/05/2021 à 13:05, Leon Romanovsky a écrit :

On Fri, May 14, 2021 at 11:52:51PM +0300, Sergey Ryazanov wrote:

quoted

On Fri, May 14, 2021 at 10:14 PM Jakub Kicinski [off-list ref] wrote:

quoted

On Thu, 13 May 2021 00:29:56 +0300 Sergey Ryazanov wrote:

quoted

No one loadable module is able to obtain netns by id since the
corresponding function has not been exported. Export it to be able to
use netns id API in loadable modules too as already done for
peernet2id_alloc().

peernet2id_alloc() is used by OvS, what's the user for get_net_ns_by_id()?

There are currently no active users of get_net_ns_by_id(), that is why
I did not add a "Fix" tag. Missed function export does not break
existing code in any way.

It is against kernel rule to do not expose APIs, even internal to the kernel,

Yep, there was no internal user, it's why I didn't add this EXPORT_*() at the
beginning.


Regards,
Nicolas