Re: [PATCH net] netns: export get_net_ns_by_id()

On Fri, May 14, 2021 at 10:14 PM Jakub Kicinski [off-list ref] wrote:

On Thu, 13 May 2021 00:29:56 +0300 Sergey Ryazanov wrote:

quoted

No one loadable module is able to obtain netns by id since the
corresponding function has not been exported. Export it to be able to
use netns id API in loadable modules too as already done for
peernet2id_alloc().

peernet2id_alloc() is used by OvS, what's the user for get_net_ns_by_id()?

There are currently no active users of get_net_ns_by_id(), that is why
I did not add a "Fix" tag. Missed function export does not break
existing code in any way.

On the other hand netns id API is incomplete without this export. You
have no way to write and test a code that uses netns id API without
manual kernel patching and rebuilding. This is annoying, but could be
trivially fixed.

Accounting for the fact that this change is trivial, closer to a fix
than to a new functionality, I prefered net tree over the net-next
tree. This way I expect the new API to reach mainstream distros faster
than over 5 years :)

-- 
Sergey