Re: [PATCH 1/1] forcedeth: Delete a redundant condition branch

On Mon, May 10, 2021 at 04:31:47PM -0700, Jakub Kicinski wrote:

On Mon, 10 May 2021 21:52:38 +0200 Andrew Lunn wrote:

quoted

quoted

This patch (and the stmmac one) removes a branch based on the fact that
it's the same as the default / catch all case. It's has a net negative
effect on the reability of the code since now not all cases are
explicitly enumerated. But it's at least the 3rd time we got that
stmmac patch so perhaps not worth fighting the bots...  

Hi Jakub

Is it the same bot every time? Or are the masters of the bots learning
what good code actually looks like and fixing their bots? Unless we
push back, the bot masters are not going to get any better at managing
their bots.

I think 2 may have been the same bot (Hulk), I found 4 previous
attempts:

https://lore.kernel.org/netdev/1616039414-13288-1-git-send-email-f.fangjian@huawei.com/ (local)
https://lore.kernel.org/netdev/1603938832-53705-1-git-send-email-zou_wei@huawei.com/ (local)
https://lore.kernel.org/netdev/1576060284-12371-1-git-send-email-vulab@iscas.ac.cn/ (local)
https://lore.kernel.org/netdev/20200602104405.28851-1-aishwaryarj100@gmail.com/ (local)

We (RDMA) got them too and decided that it is not worth to fight against them.
https://lore.kernel.org/linux-rdma/YJkByCnQGcLOIlCz@unreal/T/#m66ec31acf5e0fea5233a4b7265a3a49232492a4a (local)

Thanks