Re: [PATCH 1/1] forcedeth: Delete a redundant condition branch

On Mon, 10 May 2021 22:19:34 +0800 Zhu Yanjun wrote:

On Mon, May 10, 2021 at 9:57 PM Zhen Lei [off-list ref] wrote:

quoted

The statement of the last "if (adv_lpa & LPA_10HALF)" branch is the same
as the "else" branch. Delete it to simplify code.

No functional change.  

Thanks.
Missing Fixes?

Fixes tag is supposed to be used for functional fixes.

This patch (and the stmmac one) removes a branch based on the fact that
it's the same as the default / catch all case. It's has a net negative
effect on the reability of the code since now not all cases are
explicitly enumerated. But it's at least the 3rd time we got that
stmmac patch so perhaps not worth fighting the bots...