Thread (6 messages) 6 messages, 3 authors, 2021-04-29
STALE1872d

[PATCH] phy: nxp-c45-tja11xx: fix boolconv.cocci warnings

From: kernel test robot <hidden>
Date: 2021-04-28 16:10:41
Also in: lkml, oe-kbuild-all

From: kernel test robot <redacted>

drivers/net/phy/nxp-c45-tja11xx.c:269:25-30: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

CC: Radu Pirea (NXP OSS) <redacted>
Reported-by: kernel test robot <redacted>
Signed-off-by: kernel test robot <redacted>
---

url:    https://github.com/0day-ci/linux/commits/Radu-Pirea-NXP-OSS/Add-PTP-support-for-TJA1103/20210428-203250
base:    a5fb44b89809a00cfb85997529d8430ed0759ea5

 nxp-c45-tja11xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/phy/nxp-c45-tja11xx.c
+++ b/drivers/net/phy/nxp-c45-tja11xx.c
@@ -266,7 +266,7 @@ static int nxp_c45_ptp_adjfine(struct pt
 	u64 subns_inc_val;
 	bool inc;
 
-	inc = ppb >= 0 ? true : false;
+	inc = ppb >= 0;
 	ppb = abs(ppb);
 
 	subns_inc_val = PPM_TO_SUBNS_INC(ppb);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help