Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-04-22 20:30:08
Also in:
kernel-janitors, linux-rdma, lkml
On 4/22/21 11:00 AM, Leon Romanovsky wrote:
On Thu, Apr 22, 2021 at 10:12:33AM -0700, Bart Van Assche wrote:quoted
On 4/22/21 5:24 AM, Jason Gunthorpe wrote:quoted
On Mon, Apr 19, 2021 at 01:02:34PM -0700, Bart Van Assche wrote:quoted
On 4/18/21 11:36 PM, Marion et Christophe JAILLET wrote:quoted
The list in To: is the one given by get_maintainer.pl. Usualy, I only put the ML in Cc: I've run the script on the 2 patches of the serie and merged the 2 lists. Everyone is in the To: of the cover letter and of the 2 patches. If Théo is "Tejun Heo" ( (maintainer:WORKQUEUE) ), he is already in the To: line.Linus wants to see a "Cc: ${maintainer}" tag in patches that he receives from a maintainer and that modify another subsystem than the subsystem maintained by that maintainer.Really? Do you remember a lore link for this?Last time I saw Linus mentioning this was a few months ago. Unfortunately I cannot find that message anymore.quoted
Generally I've been junking the CC lines (vs Andrew at the other extreme that often has 10's of CC lines)Most entries in the MAINTAINERS file have one to three email addresses so I'm surprised to read that Cc-ing maintainer(s) could result in tens of Cc lines?git log mm/ commit 2b8305260fb37fc20e13f71e13073304d0a031c8 Author: Alexander Potapenko [off-list ref] Date: Thu Feb 25 17:19:21 2021 -0800 kfence, kasan: make KFENCE compatible with KASAN Make KFENCE compatible with KASAN. Currently this helps test KFENCE itself, where KASAN can catch potential corruptions to KFENCE state, or other corruptions that may be a result of freepointer corruptions in the main allocators. [akpm@linux-foundation.org: merge fixup] [andreyknvl@google.com: untag addresses for KFENCE] Link: https://lkml.kernel.org/r/9dc196006921b191d25d10f6e611316db7da2efc.1611946152.git.andreyknvl@google.com Link: https://lkml.kernel.org/r/20201103175841.3495947-7-elver@google.com Signed-off-by: Marco Elver [off-list ref] Signed-off-by: Alexander Potapenko [off-list ref] Signed-off-by: Andrey Konovalov [off-list ref] Reviewed-by: Dmitry Vyukov [off-list ref] Reviewed-by: Jann Horn [off-list ref] Co-developed-by: Marco Elver [off-list ref] Cc: Andrey Konovalov [off-list ref] Cc: Andrey Ryabinin [off-list ref] Cc: Andy Lutomirski [off-list ref] Cc: Borislav Petkov [off-list ref] Cc: Catalin Marinas [off-list ref] Cc: Christopher Lameter [off-list ref] Cc: Dave Hansen [off-list ref] Cc: David Rientjes [off-list ref] Cc: Eric Dumazet [off-list ref] Cc: Greg Kroah-Hartman [off-list ref] Cc: Hillf Danton [off-list ref] Cc: "H. Peter Anvin" [off-list ref] Cc: Ingo Molnar [off-list ref] Cc: Joern Engel [off-list ref] Cc: Jonathan Corbet [off-list ref] Cc: Joonsoo Kim [off-list ref] Cc: Kees Cook [off-list ref] Cc: Mark Rutland [off-list ref] Cc: Paul E. McKenney [off-list ref] Cc: Pekka Enberg [off-list ref] Cc: Peter Zijlstra [off-list ref] Cc: SeongJae Park [off-list ref] Cc: Thomas Gleixner [off-list ref] Cc: Vlastimil Babka [off-list ref] Cc: Will Deacon [off-list ref] Signed-off-by: Andrew Morton [off-list ref] Signed-off-by: Linus Torvalds [off-list ref]
But where does that Cc-list come from? If I extract that patch and run the get_maintainer.pl script, the following output appears: $ git format-patch -1 2b8305260fb37fc20e13f71e13073304d0a031c8 0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch $ scripts/get_maintainer.pl 0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch Alexander Potapenko [off-list ref] (maintainer:KFENCE) Marco Elver [off-list ref] (maintainer:KFENCE) Dmitry Vyukov [off-list ref] (reviewer:KFENCE) Andrey Ryabinin [off-list ref] (maintainer:KASAN) Andrey Konovalov [off-list ref] (reviewer:KASAN) Andrew Morton [off-list ref] (maintainer:MEMORY MANAGEMENT) kasan-dev@googlegroups.com (open list:KFENCE) linux-kernel@vger.kernel.org (open list) linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Additionally, please note that in my email I was referring to the MAINTAINERS file. I do not use the get_maintainers.pl script but instead select the Cc-list manually based on what I find in the MAINTAINERS file. Thanks, Bart.