Re: [PATCH net-next 12/14] net: ethernet: mtk_eth_soc: reduce unnecessary interrupts
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-04-22 16:26:13
Also in:
linux-arm-kernel, linux-mediatek, lkml
On Wed, 21 Apr 2021 21:09:12 -0700 Ilya Lipnitskiy wrote:
quoted hunk ↗ jump to hunk
@@ -1551,8 +1551,9 @@ static int mtk_napi_rx(struct napi_struct *napi, int budget) remain_budget -= rx_done; goto poll_again; } - napi_complete(napi); - mtk_rx_irq_enable(eth, MTK_RX_DONE_INT); + + if (napi_complete(napi)) + mtk_rx_irq_enable(eth, MTK_RX_DONE_INT);
Why not napi_complete_done(napi, rx_done + budget - remain_budget)? (Modulo possible elimination of rx_done in this function.)