Thread (4 messages) flat view 4 messages, 3 authors, 2021-06-04

Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

From: Jeffrey E Altman <hidden>
Date: 2021-04-21 23:42:08
Also in: linux-hardening, lkml

On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
This change looks good to me.  Although I would also be happy with a 
fallthrough statement being added instead.

Reviewed-by: Jeffrey Altman <redacted>

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help