Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-04-13 16:43:17
Also in:
linux-tegra, lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-04-13 16:43:17
Also in:
linux-tegra, lkml
On Tue, 13 Apr 2021 18:06:39 +0200 Thierry Reding wrote:
given where we are in the release cycle, I think it'd be best to revert
commit 9c63faaa931e ("net: stmmac: re-init rx buffers when mac resume
back") for now.
To summarize the discussion: the patch was meant as a workaround to fix
an occasional suspend/resume failure on one board that was not fully
root caused, and ends up causing fully reproducible suspend/resume
failures on at least one other board.
Joakim is looking at an alternative solution and Jon and I can provide
testing from the Tegra side for any fixes.
Do you want me to send a revert patch or can you revert directly on top
of your tree?Please send a revert with the justification in the commit log, and perhaps also: Link: https://lore.kernel.org/r/708edb92-a5df-ecc4-3126-5ab36707e275@nvidia.com/ (local) for those who want to dig deeper in the history. Make sure you CC relevant folks so they can review and express their opinions. Thanks!