Thread (1 message) 1 message, 1 author, 2021-03-17

Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

From: Punit Agrawal <hidden>
Date: 2021-03-17 00:39:15
Also in: stable

Hi Greg,

Greg KH [off-list ref] writes:
On Thu, Feb 25, 2021 at 09:54:06AM +0900, Punit Agrawal wrote:
quoted
From: Corinna Vinschen <redacted>

commit 2643e6e90210e16c978919617170089b7c2164f7 upstream

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not
actually cause the interrupt.  Rather, it's just bycatch while the
actual interrupt is caused by, for instance, TSICR.TXTS.

The conclusion is that the SYS WRAP is actually expected, so the
"unexpected SYS WRAP" message is entirely bogus and just helps to
confuse users.  Drop it.

Signed-off-by: Corinna Vinschen <redacted>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Aaron Brown <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
[ Due to confusion about stable rules for networking the request was
mistakenly sent to netdev only[0]. Apologies if you're seeing this
again. ]
No signed-off-by: from you?  :(
Apologies for the missing the SoB. And thank you for applying the patch
to stable even so.

[ Sorry for the long dealy in responding. Our mail system was having
issues (dropping emails randomly) and looks like this mail got caught up
during that period. ]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help